Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kustomize manifests for irsa #571

Merged
merged 17 commits into from
Mar 13, 2023

Conversation

ryansteakley
Copy link
Contributor

@ryansteakley ryansteakley commented Feb 24, 2023

Description of your changes:
Moves current s3 kustomize files into s3-static folder, andmakes changes necessary for irsa in s3.

Installation script changes coming in separate pr

Testing:

  • Unit tests pass
  • e2e tests pass
  • Details about new tests (If this PR adds a new feature)
  • Details about any manual tests performed

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@jsitu777 jsitu777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python version needs to change in make file. others look good

Makefile Outdated Show resolved Hide resolved
@ryansteakley ryansteakley merged commit 9fcd434 into awslabs:main Mar 13, 2023
ryansteakley added a commit to ryansteakley/kubeflow-manifests that referenced this pull request Apr 14, 2023
**Description of your changes:**
Moves current s3 kustomize files into s3-static folder, andmakes changes
necessary for irsa in s3.

Installation script changes coming in separate pr

**Testing:**
- [ ] Unit tests pass
- [ ] e2e tests pass
- Details about new tests (If this PR adds a new feature)
- Details about any manual tests performed

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants