-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kustomize manifests for irsa #571
Merged
ryansteakley
merged 17 commits into
awslabs:main
from
ryansteakley:kustomize-irsa-manifest
Mar 13, 2023
Merged
kustomize manifests for irsa #571
ryansteakley
merged 17 commits into
awslabs:main
from
ryansteakley:kustomize-irsa-manifest
Mar 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandreBrown
approved these changes
Mar 5, 2023
jsitu777
approved these changes
Mar 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python version needs to change in make file. others look good
awsconfigs/apps/pipeline/s3/disable-minio-server-resources.yaml
Outdated
Show resolved
Hide resolved
ryansteakley
added a commit
to ryansteakley/kubeflow-manifests
that referenced
this pull request
Apr 14, 2023
**Description of your changes:** Moves current s3 kustomize files into s3-static folder, andmakes changes necessary for irsa in s3. Installation script changes coming in separate pr **Testing:** - [ ] Unit tests pass - [ ] e2e tests pass - Details about new tests (If this PR adds a new feature) - Details about any manual tests performed By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Moves current s3 kustomize files into s3-static folder, andmakes changes necessary for irsa in s3.
Installation script changes coming in separate pr
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.